Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glibc: fixed locale support by adding on-target locale archive genera… #4434

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hsteinhaus
Copy link
Contributor

…tion

The glibc package seems to include support for localized programs. However, the current support is incomplete as there are are no means for generating a locale archive. This PR adds a systemd-based approach to generate this archive during the first boot on target, localization is available from the second boot of the target.

Unfortunately there seems to be no way to generate the archive at the build time - different archives are generated when trying so (which aren't working).

@lrusak
Copy link
Contributor

lrusak commented Nov 10, 2015

Why is this needed? To me this just looks like bloat that is not needed :)

@hsteinhaus
Copy link
Contributor Author

There are people in the world, who do not speak English (AFAIK around 6.5 billion).

Without proper locale support, almost all applications (except kodi, that brings own localization via language addons) fall back to an english user interface, which is in fact impossible to use for these people. Affected applications in stock OpenELEC that are visible to the user are e.g. VDR and it's web interfaces. Additionally, many movie titles (and broadcasted TV EPG information) in local languages, this results in wrong sorting order and sometimes even unreadable output when crippling glibc's locale mechanism.

BTW, the impact on the image size is around 5MB when GLIBC_LOCALE is set to "yes" and excactly 0 bytes when set to "no".

@lrusak
Copy link
Contributor

lrusak commented Nov 16, 2015

Why don't we package this as an add-on then?

5MB is almost a 4% increase in size of the base image. This is not a small increase.

@hsteinhaus
Copy link
Contributor Author

I think the locale support is an integral part of glibc, just like malloc() or fopen(). It is still possible to build applications on a glibc not providing this functionality, but this application will be heavily limited in its own functionality.

On the other hand, setting GLIBC_LOCALE to "no" allows to remove any traces of locale data and related services. What would be the advantage of moving them into an addon?

@vpeter4
Copy link
Contributor

vpeter4 commented Nov 17, 2015

I'm using extra locales in my lamp addon (build from eglibc package). Before starting httpd daemon I set LOCPATH environment variable with path where locales are saved. Seems to be working.

@rdorsch
Copy link

rdorsch commented Dec 28, 2015

I also hit this issue while searching for localization support of the VDR live plugin. See http://openelec.tv/forum/20-development-discussion/78261-vdr-pvr-backend-local-language-in-live-plugin for details.

@chewitt
Copy link
Contributor

chewitt commented Feb 8, 2016

@sraue - please review this and make a decision (merge or close). Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants