Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: evcs cluster widget missing alias #2807

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Jasonlee6789
Copy link
Contributor

Before
image

After
image

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2807      +/-   ##
=============================================
+ Coverage      56.01%   56.65%   +0.65%     
- Complexity      8197     8922     +725     
=============================================
  Files           2103     2167      +64     
  Lines          89017    91959    +2942     
  Branches        6560     6831     +271     
=============================================
+ Hits           49853    52093    +2240     
- Misses         37446    37990     +544     
- Partials        1718     1876     +158     

@lukasrgr
Copy link
Contributor

lukasrgr commented Oct 27, 2024

@Jasonlee6789 default is a empty string right now,


so it is possible that the title is not set, it would be better if we touch the edge config instead, then we can also get rid of the
this.alias = this.config.components[this.componentId].properties.alias ?? "Edge.Index.Widgets.EVCS.chargingStationCluster";

FYI @sebastianasen wasnt there a general change in aliases not being empty but taking the id as default?

@Jasonlee6789
Copy link
Contributor Author

Jasonlee6789 commented Oct 27, 2024

@Jasonlee6789 default is a empty string right now,

so it is possible that the title is not set, it would be better if we touch the edge config instead, then we can also get rid of the

this.alias = this.config.components[this.componentId].properties.alias ?? "Edge.Index.Widgets.EVCS.chargingStationCluster";

FYI @sebastianasen wasnt there a general change in aliases not being empty but taking the id as default?

If this previous international alias doesn't display, I find the bug is that we should use || replace ??, I have tried ||, it works, I will make a new commit.

@Jasonlee6789
Copy link
Contributor Author

After the latest commit
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants