Skip to content

Fix: evcs cluster widget missing alias#2807

Open
Jasonlee6789 wants to merge 4 commits intoOpenEMS:developfrom
girasolenergy:UI_fix_01
Open

Fix: evcs cluster widget missing alias#2807
Jasonlee6789 wants to merge 4 commits intoOpenEMS:developfrom
girasolenergy:UI_fix_01

Conversation

@Jasonlee6789
Copy link
Contributor

Before
image

After
image

@codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2807      +/-   ##
=============================================
- Coverage      59.87%   59.86%   -0.00%     
  Complexity       112      112              
=============================================
  Files           2787     2787              
  Lines         121037   121037              
  Branches        9061     9061              
=============================================
- Hits           72455    72451       -4     
- Misses         45868    45870       +2     
- Partials        2714     2716       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukasrgr
Copy link
Contributor

lukasrgr commented Oct 27, 2024

@Jasonlee6789 default is a empty string right now,


so it is possible that the title is not set, it would be better if we touch the edge config instead, then we can also get rid of the
this.alias = this.config.components[this.componentId].properties.alias ?? "Edge.Index.Widgets.EVCS.chargingStationCluster";

FYI @sebastianasen wasnt there a general change in aliases not being empty but taking the id as default?

@Jasonlee6789
Copy link
Contributor Author

Jasonlee6789 commented Oct 27, 2024

@Jasonlee6789 default is a empty string right now,

so it is possible that the title is not set, it would be better if we touch the edge config instead, then we can also get rid of the

this.alias = this.config.components[this.componentId].properties.alias ?? "Edge.Index.Widgets.EVCS.chargingStationCluster";

FYI @sebastianasen wasnt there a general change in aliases not being empty but taking the id as default?

If this previous international alias doesn't display, I find the bug is that we should use || replace ??, I have tried ||, it works, I will make a new commit.

@Jasonlee6789
Copy link
Contributor Author

Jasonlee6789 commented Oct 27, 2024

After the latest commit , the default name shows like below
image

@github-actions
Copy link

This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Sep 18, 2025
Copy link
Contributor

@da-Kai da-Kai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukasrgr you have the final say here

@da-Kai da-Kai removed the Stale label Sep 18, 2025
@Jasonlee6789
Copy link
Contributor Author

Jasonlee6789 commented Sep 30, 2025

Replaced ?? with || to handle empty string aliases, check more strictly. This ensures a fallback value is used when alias is missing or empty, like handling empty strings, which improves consistency and prevents alias display issues.

@da-Kai da-Kai requested review from sfeilmeier and removed request for lukasrgr October 1, 2025 06:09
@github-actions
Copy link

This PR has been automatically marked as stale due to inactivity

If it is still relevant, please update the PR.
Otherwise, it will be automatically closed in 14 days.

Before updating, please review our Contribution Guidelines to ensure all required information is provided.

@github-actions github-actions bot added the Stale label Jan 25, 2026
@da-Kai da-Kai requested a review from lukasrgr January 30, 2026 17:42
@da-Kai da-Kai removed the Stale label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants