Fix: evcs cluster widget missing alias#2807
Fix: evcs cluster widget missing alias#2807Jasonlee6789 wants to merge 4 commits intoOpenEMS:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2807 +/- ##
=============================================
- Coverage 59.87% 59.86% -0.00%
Complexity 112 112
=============================================
Files 2787 2787
Lines 121037 121037
Branches 9061 9061
=============================================
- Hits 72455 72451 -4
- Misses 45868 45870 +2
- Partials 2714 2716 +2 🚀 New features to boost your workflow:
|
|
@Jasonlee6789 default is a empty string right now, so it is possible that the title is not set, it would be better if we touch the edge config instead, then we can also get rid of the FYI @sebastianasen wasnt there a general change in aliases not being empty but taking the id as default? |
If this previous international alias doesn't display, I find the bug is that we should use || replace ??, I have tried ||, it works, I will make a new commit. |
|
This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs. |
|
Replaced ?? with || to handle empty string aliases, check more strictly. This ensures a fallback value is used when alias is missing or empty, like handling empty strings, which improves consistency and prevents alias display issues. |
This PR has been automatically marked as stale due to inactivityIf it is still relevant, please update the PR. Before updating, please review our Contribution Guidelines to ensure all required information is provided. |

Before

After
