Skip to content

fix: add initialization variables to fix typescript strict mode errors.#2824

Closed
Jasonlee6789 wants to merge 2 commits intoOpenEMS:developfrom
girasolenergy:UI_fix_02
Closed

fix: add initialization variables to fix typescript strict mode errors.#2824
Jasonlee6789 wants to merge 2 commits intoOpenEMS:developfrom
girasolenergy:UI_fix_02

Conversation

@Jasonlee6789
Copy link
Contributor

npx tsc --strict:

Found 1522 errors in 194 files.

Found 1505 errors in 196 files.

@codecov
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2824      +/-   ##
=============================================
+ Coverage      56.65%   59.07%   +2.43%     
- Complexity      8914     8918       +4     
=============================================
  Files           2167     1905     -262     
  Lines          91939    85257    -6682     
  Branches        6833     5807    -1026     
=============================================
- Hits           52081    50360    -1721     
+ Misses         37983    33100    -4883     
+ Partials        1875     1797      -78     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

};


private activeQueryData: string = "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review. In my opinion, this change is necessary to meet TypeScript's strict property initialization rule.
By initializing activeQueryData, it ensures it is always defined, after this change, this place TypeScript strict mode error was reduced. Without this explicit initialization, the compiler generates an error because it cannot guarantee that activeQueryData will have a value before it’s used.

@lukasrgr
Copy link
Contributor

@Jasonlee6789 thx for your contribution, im not sure, if this PR has some purpose

@Jasonlee6789
Copy link
Contributor Author

Jasonlee6789 commented Mar 12, 2025

@Jasonlee6789 thx for your contribution, im not sure, if this PR has some purpose

Thank you for your review. The purpose of this PR is to fix uninitialized variables in the UI code and explicitly add null type annotations to variables initialized as null, in order to fix TypeScript strict mode errors and prevent potential runtime errors.
The result of this PR is that after running npx tsc --strict, the number of errors was reduced from 1522 to 1505, eliminating 17 errors.

@github-actions
Copy link

This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Sep 18, 2025
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

This PR has been closed due to inactivity

It was automatically closed because there has been no recent activity.
If the PR is still relevant, please feel free to reopen and update it and add any new information.

@github-actions github-actions bot closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants