Remove $OMP directives from AeroDyn_Inflow due to Intel compiler bug #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpilation to fail when using the Intel oneAPI 2024.1.0 compiler
andrew-platt
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge.
Feature or improvement description
This PR removes the $OMP parallel directives from
AeroDyn_Inflow.f90which were causing compilation to fail when using the Intel oneAPI Fortran 2024.1.0 compiler with OpenMP enabled. This is a bug in the compiler itself, not specific to OpenFAST. There may be a slight decrease in performance for specific use cases since these were removed, but the related code has already been removed from thedevbranch.Impacted areas of the software
AeroDyn_Inflow.f90