fix highlight contrast color issue #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Now looks like this: 
In the medium term, I'd prefer we not use gold as our primary color, just because it's tricky for contrast. |
jameseastwood
approved these changes
Mar 13, 2025
Contributor
jameseastwood
left a comment
jameseastwood
left a comment
There was a problem hiding this comment.
This is a big improvement on the highlighting issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a brief description of the PR's purpose here.
not sure what color we want as a highlight, but this is the toggle to fix the issue where the highlight is the same color as the text in dark mode.
resolves #6
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status