Skip to content

Time/Timestamp converters & misc util classes #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: adv/docs
Choose a base branch
from

Conversation

peter-lawrey
Copy link
Member

@peter-lawrey peter-lawrey commented Jun 2, 2025

Time/Timestamp converters & misc util classes

This PR is a documentation-only cleanup (with one tiny test tweak) that targets all LongConverter timestamp/duration implementations plus a few stray utility classes.
No production code paths are affected.

📚 What’s inside?

Area Class / file Notes
Timestamp converters AbstractTimestampLongConverter, Milli*, Micro*, Nano*, ServicesTimestampLongConverter * Explain zoneId vs UTC semantics and the precision that each converter handles.
* Clarify parse, append, parseFormattedDate, parseTimestamp contracts and parameter roles.
* Add missing JavaDoc for private helpers (formatter creation, fraction handling, etc.).
Duration converters MicroDurationLongConverter, NanoDurationLongConverter * Document ISO-8601 expectations, nanoseconds/µs maths and helper flow.
* Detail append(StringBuilder/Bytes) behaviour.
Utility / misc WireDumper, Wires * Move @SuppressWarnings after the class-level Javadoc so IDE tool-tips render properly.
Test harness MarshallableOutBuilderTest Change HttpExchange.sendResponseHeaders(202, **-1**) so JDK doesn’t expect a body when none is sent (value 0 allowed arbitrary length).

@peter-lawrey peter-lawrey changed the title Adv/18 time converters Time/Timestamp converters & misc util classes Jun 2, 2025
@peter-lawrey peter-lawrey requested a review from tgd June 3, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant