implement missing ValueIn#sequence override for Text&YamlWire #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryShea
force-pushed
the
valuein_sequence_overload
branch
from
299ac7d to
718da14
Compare
JerryShea
commented
May 30, 2025
| Object using = buffer.get(list.size()); | ||
| list.add((T) valueIn.object(using, using.getClass())); | ||
| } | ||
| reader0.accept(this, list, buffer, bufferAdd); |
There was a problem hiding this comment.
Another dedupe, but this code did not call if (t instanceof Resettable) ((Resettable) t).reset(); before, unlike other implementations in other Wires, so making this consistent is a nice by-product
JerryShea
commented
May 30, 2025
| if (t instanceof Resettable) ((Resettable) t).reset(); | ||
| list.add(object(t, (Class<T>) t.getClass())); | ||
| } | ||
| reader0.accept(this, list, buffer, bufferAdd); |
There was a problem hiding this comment.
ValueIn#reader0 already implements this, so this dedupes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for Yaml & TextWire
was not properly implemented - it's implementation instead the overload without the
Reader.This PR removes the stubbed implementations and ensures that the
Readerargument is used. It also removes thenet.openhft.chronicle.wire.ValueIn#sequence(java.util.List<T>, java.util.List<T>, java.util.function.Supplier<T>)overloads from the Text Wires as the default impl. interface already implements the correct behaviour.