🏗🔧：pre-empt our new dark theme #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

OpenINFbot merged 107 commits into OpenINF:live from DerekNonGeneric:fix/doom-scrolling

Apr 5, 2024

Member

DerekNonGeneric commented Feb 7, 2024

coming soon

netlify bot commented Feb 7, 2024 •

edited

Loading

👷 Deploy Preview for open-inf-is processing.

Name	Link
🔨 Latest commit	`4d16b37`
🔍 Latest deploy log	https://app.netlify.com/sites/open-inf-is/deploys/65fb9939f6adf1000828106a

DerekNonGeneric linked an issue

that may be closed by this pull request

🚛 doom scrolling literally causes site to malfunction [Dark Reader] #1124

Closed

1 task

DerekNonGeneric commented

View reviewed changes

_layouts/default.html Outdated Show resolved Hide resolved

DerekNonGeneric commented

View reviewed changes

_layouts/default.html Show resolved Hide resolved

DerekNonGeneric requested a review from OpenINFbot

February 7, 2024 22:55

DerekNonGeneric assigned DerekNonGeneric and OpenINFbot

DerekNonGeneric added ♿️ Category: Accessibility 💄 Category: CSS/Styling 🌐 Category: Localization 🚸 Category: User Experience (UX) 🚧 Status: Work In Progress (WIP) ✨ Type: Enhancement ✨ Type: Feature labels

DerekNonGeneric commented

View reviewed changes

_layouts/default.html Outdated Show resolved Hide resolved

DerekNonGeneric commented

View reviewed changes

_layouts/default.html Outdated Show resolved Hide resolved

DerekNonGeneric commented

View reviewed changes

_layouts/docs.html Outdated Show resolved Hide resolved

DerekNonGeneric commented

View reviewed changes

index.html Outdated Show resolved Hide resolved

Member

OpenINFbot commented Feb 8, 2024

coming soon

sure, if you can pass the validators, you can also add the valid HTML5 web badge

OpenINF deleted a comment from OpenINFbot

DerekNonGeneric commented

View reviewed changes

_config.yml Outdated Show resolved Hide resolved

DerekNonGeneric commented

View reviewed changes

_config.yml Outdated Show resolved Hide resolved

Member Author

DerekNonGeneric commented Feb 8, 2024

while we're here, i was thinking that we could v. quickly add an actual splash page template ^^

DerekNonGeneric added the 🚅 Status: Fast Track label

Member Author

DerekNonGeneric commented Feb 8, 2024 •

edited

Loading

oh my goodness lol:

Member Author

DerekNonGeneric commented Feb 8, 2024

here is the splash template i had in mind...

🔗 https://mmistakes.github.io/minimal-mistakes/docs/layouts/#splash-page-layout

This was linked to issues Feb 8, 2024

🏷️ Structured pages (SEO) #576

Closed

🎨✨ adopting sanitize.css #851

Closed

🐛 still missing org custom templates for our error pages #1098

Closed

🏗️ separating assets for light/dark themes into different directories #1119

Closed

OpenINFbot reviewed

View reviewed changes

_config.yml Outdated Show resolved Hide resolved


          Update _config.yml

303bb17

Co-authored-by: OpenINF Bot <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>

DerekNonGeneric commented

View reviewed changes

assets/scss/collections.scss

    
            @@ -0,0 +1,26 @@
          
              ---

Member Author

DerekNonGeneric Mar 28, 2024

main thing i want to be sure we don't break before merging as-is:

the collections page has custom styles

DerekNonGeneric commented

View reviewed changes

Member Author

DerekNonGeneric left a comment

we will not be integrating rubocop in this pr;

the whole task is its own deal

DerekNonGeneric mentioned this pull request

🏗️ enabling custom site building & attaining deployment freedom #1547

Open

1 task

DerekNonGeneric and others added 4 commits

March 31, 2024 17:55


          Merge remote-tracking branch 'upstream/live' into fix/doom-scrolling

4feea9a


          Merge branch 'live' into fix/doom-scrolling

36cb3d9


          add links to sources

8f30751


          Update _config.yml

fc9ad68

Co-authored-by: OpenINF-bot <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>

OpenINFbot reviewed

View reviewed changes

Gemfile Outdated Show resolved Hide resolved


          Update Gemfile

4dbe803

Signed-off-by: OpenINF-bot <[email protected]>

OpenINFbot reviewed

View reviewed changes

_layouts/compress.html Outdated Show resolved Hide resolved

OpenINFbot and others added 2 commits

March 31, 2024 18:09


          Apply suggestions from code review

c8dcc3e

Signed-off-by: OpenINF-bot <[email protected]>


          Restyled by whitespace

92143b9

DerekNonGeneric commented

View reviewed changes

_layouts/compress.html Outdated

    
            @@ -1,5 +1,5 @@
          
              ---

              ## 

              ##

Member Author

DerekNonGeneric Mar 31, 2024

right, here is where dev and prod matters; also we are removing these (as mentioned)


          Delete _layouts/compress.html

d4f56e2

Signed-off-by: OpenINF-bot <[email protected]>

OpenINFbot added 🌗 P2: Medium and removed 🗳️ Status: Author Ready 🔥 P0: Critical labels

DerekNonGeneric force-pushed the live branch from f1a3fd0 to 62bd1ad Compare

April 1, 2024 23:18


          Merge branch 'live' into fix/doom-scrolling

b579160

Signed-off-by: OpenINF-bot <[email protected]>

DerekNonGeneric force-pushed the live branch 4 times, most recently from 5654a37 to 33d717a Compare

April 5, 2024 19:19


          Merge branch 'live' into fix/doom-scrolling

2e7bb7b

OpenINFbot approved these changes

View reviewed changes

OpenINFbot merged commit b15cc0e into OpenINF:live

DerekNonGeneric added a commit that referenced this pull request


          Revert "🏗🔧：pre-empt our new dark theme #1131"

f4f86a8

This reverts commit b15cc0e.

DerekNonGeneric added a commit that referenced this pull request


          Revert "Revert "🏗🔧：pre-empt our new dark theme #1131""

774f76c

This reverts commit f4f86a8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♿️ Category: Accessibility 💄 Category: CSS/Styling 🌐 Category: Localization 🚸 Category: User Experience (UX) 💎 Code: Ruby 🌗 P2: Medium 🛄 Status: Claimed 🚅 Status: Fast Track 🚧 Status: Work In Progress (WIP) 🗒️ todo ✨ Type: Enhancement ✨ Type: Feature