Generate features into the server directory and not the src #1877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please be aware that the dev-it test does not get run for the Windows platform because of how often it would fail (due to file contingency and locks on Windows)....so the fact that all the Windows builds passed is no indication of the correctness of the code changes in this PR |
|
Good point, thanks. I was just researching why one group of tests would consistently pass and another consistently fail. I have some dev mode test fixes but we also have other work to do to merge this change with dev mode function. |
TrevCraw
reviewed
May 15, 2025
.../generate-features-it/src/test/java/net/wasdev/wlp/test/dev/it/BaseGenerateFeaturesTest.java
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/GenerateFeaturesMojo.java
Show resolved
Hide resolved
TrevCraw
reviewed
May 15, 2025
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/GenerateFeaturesMojo.java
Outdated
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/GenerateFeaturesMojo.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
turkeylurkey
force-pushed
the
issue-1875
branch
2 times, most recently
from
1ec26aa to
8878a03
Compare
turkeylurkey
added
the
generateFeatures
TrevCraw
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of issue #1875