Skip to content

Simplify the sed command used to generate plugin header files, closes #1592 (hopefully) #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 30, 2020
Merged

Simplify the sed command used to generate plugin header files, closes #1592 (hopefully) #1608

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ae4879d
Comment what the original code did
peternewman Jan 21, 2020
abe6bc7
Switch to a simpler sed command
peternewman Jan 21, 2020
13ae375
Clarify some of the comments
peternewman Jan 25, 2020
c1be091
Merge branch 'master' into e1.37-2
peternewman Jan 27, 2020
c3daf5c
Remove some unnecessary backslashes
peternewman Jan 27, 2020
15b6edb
Merge branch 'e1.37-2' of https://github.com/peternewman/ola into e1.…
peternewman Jan 27, 2020
694cdf1
Merge branch 'master' into e1.37-2
peternewman Mar 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/convert_README_to_header.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ fi
plugin=`basename "$path"`;
outfilename=`basename $outfile`;

# See http://stackoverflow.com/a/16576291
# On Mac OS's sed, \n is not recognized as a newline character, but
# \[actual newline] works
desc=`sed -e ':a' -e 'N' -e '$!ba' -e 's/\"/\\\"/g' -e 's/\n/\\\\n"\\
"/g' "$path/README.md"`;
#s/"/\\"/g - replace " with \" throughout
#1!s/^/"/g - Apart from the first line, add a " to the start of each line
#$!s/$/\\\\n"/g - Apart from the last line, add a \\n (i.e. an escaped newline)
#and a " to the end of each line
desc=`sed -e 's/"/\\"/g' -e '1!s/^/"/' -e '$!s/$/\\\\n"/' "$path/README.md"`;

identifier=`echo "PLUGINS_${plugin}_${outfilename%.h}_H_" | tr '[:lower:]' '[:upper:]'`

Expand Down