Update workflow to run on PR's and upload build (#148) #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rzach Could you please approve the workflow run so I can find out what naming scheme is used. |
|
It works like so: https://github.com/StanFromIreland/OpenLogic/actions/runs/14145840986 the build is uploaded and can be downloaded from the artifacts section. |
|
Done |
|
Does this look good to you?
|
|
It does! I'm not 100% sure what's happening but this looks great. Can I just go ahead and merge it? |
|
Yep! It just uploads the file from the build so you can easily view it from prs! I don't know of a nice online solution like RTD (see cpython prs for example) |
|
Thanks! |
rzach
pushed a commit
that referenced
this pull request
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#148