Issue 1033 - Fix Infinite Payload Range Looping

[cmbenne3]

Summary

This PR fixes a bug where setting payload_range in aviary inputs triggered an infinite looping of trying to generate a payload_range diagram.

The quick fix is to reset the aviary inputs value immediately after generate_payload_range has been set, ahead of running the first off design problem. Unfortunately this leaves mismatched aviary inputs.settings.payload_range = False and prob.generate_payload_range = True for the original parent problem. It is unclear how to fix this without introducing another variable, which seems unecessary!

There is also a small change to grab max_iter from the design/sizing problem and parse that to the optimizer for the off_design problems. This solved an issue where off_design problems failed due to hitting the default max iteration limit (50).

Related Issues

• Resolves csv input of settings:payload_range results in infinite looping of payload range code #1033

Backwards incompatibilities

None

New Dependencies

None

[jkirk5]

We should test this as well - the original payload-range test doesn't work using the flag because we needed to get access to the off-design problems in order to check their values. I don't know if we can avoid running the whole payload-range suite twice but if would be nice if we can find a way to do so