Serialize accesses to parallelized syrk functions from multiple calle…#5619
Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom Jan 20, 2026
Conversation
…rs, like it was already done for GEMM in level3_thread.c and GEMM3M in level3_gemm3m_thread.c
Collaborator
|
Thanks, not sure why that got missed. I worry that something similar might be needed for getrf/potrf as well |
Contributor
Author
|
Thanks for pointing this out! I'll prioritize checking getrf and potrf soon and follow up with any necessary changes. |
Contributor
Author
|
@martin-frbg Hi Martin, I've checked the code and agree that getrf/potrf are missing the concurrency-limiting code as well. Could you confirm if I should create a new PR to fix this bug? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rs, like it was already done for GEMM in level3_thread.c and GEMM3M in level3_gemm3m_thread.c