FIX getRepoAccess() callers to pass instance URL as first argument #3737
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 2fae59b changed getRepoAccess() signature to require an instance URL as the first parameter, but these three callers were not updated. This caused getConfig(instance) to look up tokens using the dataset ID instead of the URL, resulting in "Run openneuro login" errors. Co-Authored-By: Claude Opus 4.5 <[email protected]>
There was a problem hiding this comment.
Pull request overview
Fixes CLI authentication failures by updating remaining getRepoAccess() call sites to pass the instance URL as the first argument, aligning with the updated function signature and ensuring tokens are looked up using the correct config key.
Changes:
- Update
uploadcommand to callgetRepoAccess(clientConfig.url, datasetId). - Update
downloadcommand to callgetRepoAccess(clientConfig.url, datasetId). - Update
special-remoteto deriveinstanceUrlfrom the provided URL and callgetRepoAccess(instanceUrl, datasetId).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cli/src/commands/upload.ts | Passes configured instance URL into getRepoAccess() so repo tokens resolve correctly during upload. |
| cli/src/commands/download.ts | Passes configured instance URL into getRepoAccess() so repo tokens resolve correctly during download. |
| cli/src/commands/special-remote.ts | Extracts instance origin from the remote URL and passes it into getRepoAccess() for correct token lookup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to upload a new dataset with the CLI (v4.4.0), but kept getting login errors despite having logged in multiple times. The following was fixed with Claude. Now I'm able to upload the dataset (ongoing).
Claude's comment: