Skip to content

MapFindFeature: Exclude hidden and protected objects #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 17, 2025
Merged

MapFindFeature: Exclude hidden and protected objects #2371

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a8195c6
MapFindFeature: Exclude hidden and protected objects
dl3sdo Apr 27, 2025
8c6c8f0
Factor out isSelectable()
dg0yt May 12, 2025
1e1ca1c
Revert new search functor
dg0yt May 12, 2025
116b343
Use single walk for "Find next"
dg0yt May 12, 2025
34a1c2d
Cleanup
dg0yt May 12, 2025
71d742c
Fixup
dg0yt May 12, 2025
1122a73
Fix passing of query
dl3sdo May 12, 2025
fb09aa0
Search pivot object in all objects
dg0yt May 13, 2025
b0dcb5a
Code polishing
dl3sdo May 13, 2025
1bf23da
Add test
dl3sdo May 13, 2025
b401a03
Move and revise testFindFeatures
dg0yt May 14, 2025
b223b89
Partially revert polishing
dg0yt May 14, 2025
5b11077
Refactoring, cont.
dg0yt May 14, 2025
e6b874c
Refactoring, oversight and cont.
dg0yt May 14, 2025
332f4ad
Move error message to makeQuery()
dg0yt May 14, 2025
b9cf6b3
Restore clearing the selection on error
dg0yt May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/gui/map/map_find_feature.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,23 +198,23 @@ void MapFindFeature::findNext()
Object* next_match = nullptr; // the next match after pivot_object
map->clearObjectSelection(false);

auto search = [&first_match, &pivot_object, &next_match](Object* object) {
auto search = [&](Object* object) {
if (next_match)
return;

bool after_pivot = (pivot_object == nullptr);
if (object == pivot_object)
pivot_object = nullptr;

if (isSelectable(object))
if (isSelectable(object) && query(object))
{
if (after_pivot)
next_match = object;
else if (!first_match)
first_match = object;
}
};
map->getCurrentPart()->applyOnMatchingObjects(search, std::cref(query));
map->getCurrentPart()->applyOnAllObjects(search);
Copy link
Member

@dg0yt dg0yt May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting part of my change here: The current object might no longer match the query, but we still want to see it when determining the next match.

if (!next_match)
next_match = first_match;
if (next_match)
Expand Down