Skip to content

OgrFileExport: Exclude objects with hidden or helper symbols #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

OgrFileExport: Exclude objects with hidden or helper symbols #2421

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e682a9
OgrFileExport: Exclude objects with hidden or helper symbols
dl3sdo Oct 3, 2025
0f96380
OgrFileExport: Refactoring
dl3sdo Oct 10, 2025
d7aa30a
OgrFileExport: Unified solution
dl3sdo Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/gdal/ogr_file_format.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2016-2020 Kai Pastor
* Copyright 2016-2020, 2025 Kai Pastor
*
* This file is part of OpenOrienteering.
*
Expand Down Expand Up @@ -1975,23 +1975,23 @@ bool OgrFileExport::exportImplementation()

auto is_point_object = [](const Object* object) {
const auto* symbol = object->getSymbol();
return symbol && symbol->getContainedTypes() & Symbol::Point;
return symbol && !symbol->isHidden() && !symbol->isHelperSymbol() && symbol->getContainedTypes() & Symbol::Point;
};

auto is_text_object = [](const Object* object) {
const auto* symbol = object->getSymbol();
return symbol && symbol->getContainedTypes() & Symbol::Text;
return symbol && !symbol->isHidden() && !symbol->isHelperSymbol() && symbol->getContainedTypes() & Symbol::Text;
};

auto is_line_object = [](const Object* object) {
const auto* symbol = object->getSymbol();
return symbol && (symbol->getType() == Symbol::Line
|| (symbol->getType() == Symbol::Combined && !(symbol->getContainedTypes() & Symbol::Area)));
return symbol && !symbol->isHidden() && !symbol->isHelperSymbol()
&& (symbol->getType() == Symbol::Line || (symbol->getType() == Symbol::Combined && !(symbol->getContainedTypes() & Symbol::Area)));
};

auto is_area_object = [](const Object* object) {
const auto* symbol = object->getSymbol();
return symbol && symbol->getContainedTypes() & Symbol::Area;
return symbol && !symbol->isHidden() && !symbol->isHelperSymbol() && symbol->getContainedTypes() & Symbol::Area;
};

if (quirks & SingleLayer)
Expand Down