Add backport of Qt 5.15 Android content URI support #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
commented
Mar 8, 2021
Member
Author
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
Additional changes needed.
| + | ||
| + String visitedUri = matchedTreeUri.toString(); | ||
| + while (true) { | ||
| + Log.w(QtTAG, "*** VISITING: " + visitedUri); |
Member
Author
There was a problem hiding this comment.
TODO: Remove this logging entry.
| + String visitedUri = matchedTreeUri.toString(); | ||
| + while (true) { | ||
| + Log.w(QtTAG, "*** VISITING: " + visitedUri); | ||
| + // Populate m_cachedUris with children of matchedTreeUri |
Member
Author
There was a problem hiding this comment.
s/matchedTreeUri/visitedUri/
|
|
||
| public static boolean openURL(Context context, String url, String mime) | ||
| { | ||
| + url = getCanonicalContentUri(url); |
Member
Author
There was a problem hiding this comment.
Limit this to content: URIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.