Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZED Camera Support With OPT #123

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

chanbrown007
Copy link

Please see README - ZED WITH OPT INSTALL ONLY FOLLOW THIS IF USING ZED.txt for installation and running instructions.

add_executable(ground_based_people_detector_sr apps/ground_based_people_detector_node_sr.cpp)
SET_TARGET_PROPERTIES(ground_based_people_detector_sr PROPERTIES LINK_FLAGS -L${PCL_LIBRARY_DIRS})
target_link_libraries(ground_based_people_detector_sr ${PROJECT_NAME} ${catkin_LIBRARIES} ${PCL_LIBRARIES} vtkHybrid vtkRendering)
#add_executable(ground_based_people_detector_sr apps/ground_based_people_detector_node_sr.cpp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, the files for the SwissRanger are not built. I think we should maintain them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,4 @@
1.59075e-37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -370,24 +370,38 @@ open_ptrack::detection::GroundBasedPeopleDetectionApp<PointT>::preprocessCloud (
PointCloudPtr cloud_filtered(new PointCloud);
pcl::VoxelGrid<PointT> voxel_grid_filter_object;
if (apply_denoising_)
{
//std::cout << "APPLY DENOISING" << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these debug lines should not go to the repo. If now you don't need them any more, can you remove them?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

std::vector<int> myvector;

int count = 0;
for(pcl::PointCloud<pcl::PointXYZRGB>::iterator it = no_ground_cloud_->begin(); it != no_ground_cloud_->end(); it++)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try with the method built-in in PCL for removing NaNs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I have tried doing this:
PointCloudPtr removedNaN_cloud(new PointCloud);
std::vector indices;
pcl::removeNaNFromPointCloud(*no_ground_cloud_, *removedNaN_cloud, indices);
no_ground_cloud_ = removedNaN_cloud;

However when i do that I get the error:
"Invalid (NaN, Inf) point coordinates given to radiusSearch!"

Which is why I ended up creating my own remove NaN

@@ -0,0 +1,105 @@
# zed-ros-wrapper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the Zed wrapper should go in a separate repo, outside open_ptrack, as we did for the other sensors.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants