Set installation root dir from setup.py #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdohnal
approved these changes
May 6, 2024
| @@ -63,7 +63,7 @@ all-local: .stamp-distutils-in-builddir config.py cupshelpers/config.py | |||
|
|
|||
| # Use distutils to install the module. | |||
| install-exec-local: .stamp-distutils-in-builddir | |||
| $(PYTHON) setup.py install --prefix=$(DESTDIR)$(prefix) | |||
| $(PYTHON) setup.py install --root=$(DESTDIR) --prefix=$(DESTDIR)$(prefix) | |||
There was a problem hiding this comment.
Hi Rafael,
thank you for the PR!
Actually the similar fix was brought into Fedora when Python 3.12 was introduced and it works fine since that:
--- a/Makefile.am
+++ b/Makefile.am
@@ -63,7 +63,7 @@ all-local: .stamp-distutils-in-builddir config.py cupshelpers/config.py
# Use distutils to install the module.
install-exec-local: .stamp-distutils-in-builddir
- $(PYTHON) setup.py install --prefix=$(DESTDIR)$(prefix)
+ $(PYTHON) setup.py install --root $(DESTDIR) --prefix=$(prefix)
# Uninstall the module, crossing our fingers that we know enough
# about how distutils works to do this. Unfortunately, distutils
I see the same patch was used in other project - AOSC-Dev/aosc-os-abbs@7b298dd - so I will go with this fix.
But either way thank you for PR! I'll merge it and then update it to match with Fedora changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357 #355