Replace obsolete AssociationAttribute with new EntityAssociationAttribute on client #509
Merged
Daniel-Svensson merged 14 commits intoOpenRIAServices:mainfrom Jun 9, 2024
Merged
Conversation
* Add EntityAssociationAttribute to use instead
Daniel-Svensson
changed the title
Daniel-Svensson
changed the title
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // that takes string arguments in constructor insterad of Arrrays as EntityAssociationAttribute does | ||
| else if (typeof(T) == typeof(string) && ctorArg.ArgumentType.IsArray) | ||
| { | ||
| value = (T)(object)string.Join(", ", ((IEnumerable<CustomAttributeTypedArgument>)ctorArg.Value).Select(arg => arg.Value?.ToString() ?? "null")); |
Check warning
Code scanning / CodeQL
Useless upcast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace obsolete
AssociationAttributewith newEntityAssociationAttributeon clientEntityAssociationAttributeinternally for all logicAssociationAttributeis still discovered and mapped to anEntityAssociationAttributein case an old version of the code generation has been used.EntityAssociationAttributeinstead ofAssociationAttributePR Classification
This pull request involves an API change, specifically replacing the
AssociationAttributeclass with theEntityAssociationAttributeclass across several files.PR Summary
The pull request primarily focuses on the transition from
AssociationAttributetoEntityAssociationAttributein the codebase.EntityAssociationAttribute.csfile has been added, defining the new class used to mark an Entity member as an association.AssociationAttributeclass has been replaced with theEntityAssociationAttributeclass in multiple files includingChangeSetBuilder.cs,Entity.cs,EntityCollection.cs,EntityRef.cs,EntitySet.cs,MetaMember.cs, andIEntityCollection.cs.MetaMember.cs, theAssociationAttributeproperty has been replaced with theEntityAssociationAttributeproperty, with added logic to handle the transition.AttributeGeneratorHelper.csfile inOpenRiaServices.Tools.TextTemplatehas been updated to translate allAssociationAttributetoEntityAssociationAttributeon the client.EntityAssociationAttributeBuilder.csfile has been added in theOpenRiaServices.Toolsnamespace, defining a custom attribute builder forEntityAssociationAttributeinstances.