railway_manager_interface: update openapi #14092
Open
+450
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
There are mentions of GESICO in this openAPI |
clarani
reviewed
Nov 21, 2025
Contributor
clarani
left a comment
clarani
left a comment
There was a problem hiding this comment.
Could you launch the generation of the front-end types please ? 🙏
JulesPeignier
force-pushed
the
jules/update-openapi-tartine
branch
from
cde7011 to
4e81490
Compare
Contributor
Author
@younesschrifi @achrafmohye were doing it yesterday, maybe they have some news |
Castavo
reviewed
Nov 21, 2025
Castavo
reviewed
Nov 21, 2025
Comment on lines
184
to
185
| allOf: | ||
| - $ref: '#/components/schemas/StepType' |
Contributor
There was a problem hiding this comment.
Can't it be the following ?
Suggested change
| allOf: | |
| - $ref: '#/components/schemas/StepType' | |
| ref: '#/components/schemas/StepType' |
Contributor
Author
There was a problem hiding this comment.
If we want to keep VIA as default value we need to keep also allOf, i don't have a strong opinion about it
younesschrifi
force-pushed
the
jules/update-openapi-tartine
branch
from
4e81490 to
cf50d1e
Compare
emersion
reviewed
Nov 21, 2025
emersion
reviewed
Nov 21, 2025
emersion
reviewed
Nov 21, 2025
emersion
reviewed
Nov 21, 2025
emersion
reviewed
Nov 21, 2025
emersion
reviewed
Nov 21, 2025
emersion
reviewed
Nov 21, 2025
emersion
reviewed
Nov 21, 2025
JulesPeignier
force-pushed
the
jules/update-openapi-tartine
branch
from
7e7686d to
eca9fb2
Compare
emersion
reviewed
Nov 21, 2025
younesschrifi
force-pushed
the
jules/update-openapi-tartine
branch
2 times, most recently
from
d31cb36 to
58a3037
Compare
JulesPeignier
force-pushed
the
jules/update-openapi-tartine
branch
from
58a3037 to
02068b3
Compare
JulesPeignier
commented
Nov 21, 2025
| Location: | ||
| properties: | ||
| uic: | ||
| type: number |
Contributor
Author
There was a problem hiding this comment.
It should be an int i think
JulesPeignier
force-pushed
the
jules/update-openapi-tartine
branch
from
02068b3 to
7f79d5a
Compare
Contributor
Author
|
i think it's ok now |
emersion
reviewed
Nov 21, 2025
generate models for railway manager Signed-off-by: Jules Peignier <[email protected]>
JulesPeignier
force-pushed
the
jules/update-openapi-tartine
branch
from
7f79d5a to
99b2bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.