core: paths: add object length to ranges #14102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eloi Charpentier <[email protected]>
hhirtz
reviewed
Nov 21, 2025
| init { | ||
| require(length >= 0.meters) | ||
| require(pathEnd - pathBegin == length) | ||
| require(objectEnd <= objectLength) |
Member
There was a problem hiding this comment.
Is the range always within the object? Why can objectBegin be negative but objectEnd cannot go past the object's length? just asking, since it doesn't seem we build a range with objectBegin < 0 in tests
Comment on lines
+50
to
+54
| val pathEnd: Offset<TrainPath> | ||
| get() = pathBegin + length | ||
|
|
||
| val objectEnd: Offset<OffsetType> | ||
| get() = objectBegin + length |
Member
There was a problem hiding this comment.
Missing doc comments that have been removed from the default constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose earlier to not include the object length to the ranges, for "memory concerns". But I now regret that choice, especially because directed/undirected projections would be a lot easier with object lengths.
And we had redundant variables anyway, so it could fit without adding an extra one.