-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to facilitate production usage of webhooks and workout data from Concept2 #9
Open
MoralCode
wants to merge
45
commits into
main
Choose a base branch
from
cl_webhook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tervals, heart rate, and full results (retrieved from a GET call on C2's api rather than from their webhook payload)
this may be hard to undo as re-separating them if a better way is found later may be a more breaking change than this merge
- also renamed endDate value back to date to prevent creating breaking changes
… the other helpers do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR facilitates production use of Webhooks to automatically synchronize data from Concept2 and supersedes #8, which I didn't have the ability to edit.
This commit contains several key contributions, largely from @pfredCL:
C2HeartRate
,C2Intervals
,C2Splits
,C2Workout
)C2Results
to handle additional data on intervals, heart rate, workout results, and rest data available from other result related endpoints in the Concept2 API.types/index.dart
)freezed
package once c2logbook is published #5)C2FullResults
andC2DetailedResult
) for backwards compatibility with existing usecases.Deprecated functionality Migration Guide
In order to be safe from the removal of the deprecated features in this PR:
C2FullResults
withC2Results
, which has been updated to support the additional fields that were introduced inC2FullResults
C2FullResults.date
field withC2Results.endDate
C2DetailedResult
. Instead, either use methods onC2Logbook
to fetch data or manually extract the JSON data from thedata
key of the JSON response from the Concept2 API and feed it intoC2Results.fromJson()
or another supported type