Changes TaggerFstCorpus to allow SolrDocuments that do not define the "storedField" #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fields of processed documents. This is important to support the creation of FST Corpora for Vocabularies where some entries (Solr Documents) do not have a label (e.g. in multilingual scenarios)
dsmiley
added a commit
that referenced
this pull request
Jul 4, 2013
Changes TaggerFstCorpus to allow SolrDocuments that do not define the "storedField"
|
Nice; I liked the addition of the warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two possible reasons, why
IndexableField storedField = document.getField(storedFieldName);returns null:stored=false) and therefor the labels for the current entity are missing in the IndexIf
storedFieldNamerepresents the field use to store labels in a specific language (e.g. German) it is a total valid case that an entity might not have a label in that specific language.This change will allow to create per language FST corpora as suggested by Issue #5