Merge pull request #3 from OpenShock/feature/better-gpio-pin-handling

Use signed 8-bit integers for gpio pin types
OpenShock · Oct 7, 2024 · 58c0c64 · 58c0c64
2 parents 5a234f3 + 9a4dd47
commit 58c0c64
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/HubConfig.fbs b/HubConfig.fbs
@@ -2,7 +2,7 @@ namespace OpenShock.Serialization.Configuration;
 
 table RFConfig {
   /// The GPIO pin connected to the RF modulator's data pin for transmitting (TX)
-  tx_pin:uint8;
+  tx_pin:int8;
 
   /// Whether to transmit keepalive messages to keep the shockers from entering sleep mode
   keepalive_enabled:bool;
@@ -12,7 +12,7 @@ table EStopConfig {
   enabled:bool;
 
   /// The GPIO pin connected to the E-Stop button
-  gpio_pin:uint8;
+  gpio_pin:int8;
 }
 
 table WiFiCredentials {

diff --git a/HubToLocalMessage.fbs b/HubToLocalMessage.fbs
@@ -52,7 +52,7 @@ enum SetGPIOResultCode : uint8 {
   InternalError = 2
 }
 table SetRfTxPinCommandResult {
-  pin:uint8;
+  pin:int8;
   result:SetGPIOResultCode;
 }
 
@@ -62,7 +62,7 @@ table SetEstopEnabledCommandResult {
 }
 
 table SetEstopPinCommandResult {
-  gpio_pin:uint8;
+  gpio_pin:int8;
   result:SetGPIOResultCode;
 }
 

diff --git a/LocalToHubMessage.fbs b/LocalToHubMessage.fbs
@@ -56,13 +56,13 @@ table AccountUnlinkCommand {
   placeholder:bool;
 }
 table SetRfTxPinCommand {
-  pin:uint8;
+  pin:int8;
 }
 table SetEstopEnabledCommand {
   enabled:bool;
 }
 table SetEstopPinCommand {
-  pin:uint8;
+  pin:int8;
 }
 
 union LocalToHubMessagePayload {