Skip to content

Change generate-models for models.yml split #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Change generate-models for models.yml split #2943

wants to merge 5 commits into from

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom added this to the 4.3 milestone May 14, 2025
@luisa-beerboom luisa-beerboom self-assigned this May 14, 2025
@luisa-beerboom luisa-beerboom mentioned this pull request May 15, 2025
Open
@luisa-beerboom luisa-beerboom marked this pull request as ready for review May 19, 2025 15:46
@luisa-beerboom luisa-beerboom requested a review from hjanott May 19, 2025 15:47
hjanott
hjanott approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@hjanott hjanott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
Just want to mention that #2950 is related. An idea would be to retain the order in which the classes are generated.

@hjanott hjanott assigned luisa-beerboom and unassigned hjanott May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjanott hjanott hjanott approved these changes

Assignees

@luisa-beerboom luisa-beerboom

Labels
clean up
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@luisa-beerboom @hjanott