-
Notifications
You must be signed in to change notification settings - Fork 7
Add WCON viewers #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JSON libraries for WCON generation
Aklein/generate wcon
Update build.yml
* master: Update build.yml
Test across more versions
Test more versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds new viewers and enhancements for handling WCON files in the worm simulation project.
- Generate WCON files from simulation data
- Introduce CSV-based and WCON-based viewers with CLI options
- Add a plotting utility to generate PNG images from WCON data and update the build workflow
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
WormSim/Model/generate_wcon.py | New module to generate WCON files from simulation data |
WormSim/Model/WormViewCSV.py | New CSV-based viewer for rendering simulation data |
WormSim/Model/WormView.py | Updated WCON viewer with additional CLI options and perimeter generation logic |
WormSim/Model/WormPlot.py | New viewer to generate PNG plots from WCON files |
README.md | Minor documentation update |
.github/workflows/build.yml | Workflow update to include jsonschema dependency |
Files not reviewed (3)
- WormSim/Model/simdata_test.csv: Language not supported
- WormSim/Model/simdata_test.wcon: Language not supported
- WormSim/Model/test_all.sh: Language not supported
Comments suppressed due to low confidence (1)
WormSim/Model/WormViewCSV.py:30
- [nitpick] Consider renaming the variable 'Objects' to 'objects' to adhere to Python naming conventions.
Objects = genfromtxt("objects.csv", delimiter=",")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.