-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespaces #17
base: main
Are you sure you want to change the base?
Namespaces #17
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Hans-Martin von Gaudecker <[email protected]>
Co-authored-by: Hans-Martin von Gaudecker <[email protected]>
Co-authored-by: Hans-Martin von Gaudecker <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 96.46% 97.71% +1.24%
==========================================
Files 8 10 +2
Lines 453 699 +246
==========================================
+ Hits 437 683 +246
Misses 16 16 ☔ View full report in Codecov by Sentry. |
I found a small bug in Suppose I have a tree with two leafs: a function called Now, I guess the preferred solution is to get rid of the implicit assumption all together. To do this, we probably have to rewrite a few functions. I added a failing test such that we don't forget about this. In the mean time, I reversed the implicit assumption via 811f211 such that it suits the application. |
Summary of Changes
Implement namespaces as described in #14.