Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be something wrong about the stochastics in PyLCM.
In this PR, I want to validate and potentially fix the parts in PyLCM that work with stochastics. This will most likely close #39 and #63.
In particular, we have to answer the following questions:
I believe here we must start form the mathematics again, and then work ourselves down to the implementation.
What we (most likely) need
Ideally, we check that the transition matrices and the model are consistent as early as possible; i.e., inside the
solve(params)orsimulate(params)call, but before any computationQ_and_F.pytosolve_brute.py(helps in modularization, cleans up Q_and_F code)