Skip to content

Fix/edit hero img and cta in bo #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Stef-Rousset
Copy link
Collaborator

🎩 Description
The aim of this PR is to fix a bug that occurs on decidim-0.29.osp.dev, but not in local env or docker. When trying to edit a "Hero image and CTA" block in assembly landing page, the error to fix is :

ActionView::Template::Error (undefined local variable or method `parent_assembly' for #<ActionView::Base:0x000000095185c0>):
1: <% content_for :breadcrumb_context_menu do %>
2:   <div class="process-title-content-breadcrumb-container-right">
3:     <% if allowed_to? :create, :assembly, assembly: parent_assembly %>
4:       <% link = defined?(parent_assembly) ? new_assembly_path(parent_id: parent_assembly&.id) : new_assembly_path %>
5:       <%= link_to link, class: "button button__sm button__transparent process-title-content-breadcrumb-container-right-link" do %>
6:         <%= icon "add-line", class: "w-4 h-4" %>
decidim (af8d33194b3b) decidim-assemblies/app/views/layouts/decidim/admin/assemblies.html.erb:3

📌 Related Issues
Odoo card

Testing

  • Go to the BO
  • Go to an assembly and than to Landing page
  • Click on edit button for the Hero image and CTA, and see that you can access the page without error.
  • You can also check that you can add an image

@Stef-Rousset Stef-Rousset changed the base branch from main to develop March 5, 2025 14:09
@Stef-Rousset Stef-Rousset marked this pull request as ready for review March 5, 2025 17:07
Copy link
Collaborator

@AyakorK AyakorK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! However, maybe we should have fixed the CI in another PR, considering the number of files added !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants