Skip to content

Conversation

Amustache
Copy link
Contributor

No description provided.

@Amustache Amustache requested a review from clementbiron July 1, 2022 16:00
@clementbiron clementbiron changed the title MAAS: Freenow MAAS: add Freenow Jul 11, 2022
@martinratinaud
Copy link
Member

Hello @Amustache I've added some commits to fine tune your proposal.

It seems that the privacy policy page is containing both english and french versions.
If you want to keep only the french version you can use that kind of syntax

"Privacy Policy": {
      "fetch": "https://free-now.com/fr/driver-privacy-policies/",
      "select": {
        "startBefore": ".content h2:nth-of-type(1)",
        "endBefore": ".content h2:nth-of-type(4)"
      }
    },

Nevertheless, the selectors are not bullet proof as only adding a h2 in the file would break the selector.
@MattiSG what do you suggest here, I could not find a better way, as we can't yet use CSS selector :contains.

Thanks

@MattiSG
Copy link
Member

MattiSG commented Jul 20, 2022

I think range selectors are very appropriate in such a case 🙂

It is important that the France instance contains only documents in French.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants