add tesla #610
Open
add tesla #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cli4d
requested changes
Jan 30, 2025
Comment on lines
+1
to
+12
| { | ||
| "name": "Tesla", | ||
| "documents": { | ||
| "Privacy Policy": { | ||
| "fetch": "https://www.tesla.com/fr_fr/legal/privacy", | ||
| "select": { | ||
| "startBefore": ".tds-shell h1", | ||
| "endBefore": ".tds-shell footer" | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Hi @GDefrevillePEReN I noticed these selectors where including the header. So I found a simpler selector to use. Also fetching was bringing up a 403, so I enabled client scripts to resolve that.
Given this is your fork, I cannot actualize these changes. So you can add this into the file to bring on board the changes I talked about
{
"name": "Tesla",
"documents": {
"Privacy Policy": {
"fetch": "https://www.tesla.com/fr_fr/legal/privacy",
"select": [
"#tdsonecolumn--UJnUWI7OCdU"
],
"executeClientScripts": true
}
}
}
|
Back to review this PR after the earlier suggested changes. It seems the website blocked our bot as it brings up a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.