Skip to content

Conversation

GDefrevillePEReN
Copy link
Contributor

No description provided.

Copy link
Member

@Cli4d Cli4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GDefrevillePEReN,

Thank you for taking the time to make this contribution. I have reviewed it and would like to confirm a few things before approving it. While the declaration is clear and readable, the service appears to have multiple privacy statements, as noted on its website. Since we only have one terms type for these documents, I think it would be best to merge them all into a single privacy policy terms type.

I would like to hear @OpenTermsArchive/core's thoughts on this matter.

@clementbiron
Copy link
Member

I share your point of view Clifford, the best thing is to bring documents together.

Copy link
Member

@Cli4d Cli4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the previous review and suggestion. I have managed to combine the 3 privacy policies of Volvo Cars. Please see the suggested change and merge them. I would have added the changes direclty but can't since it exists in a fork.

Comment on lines +1 to +13
{
"name": "Volvo Cars",
"documents": {
"Privacy Policy": {
"executeClientScripts": true,
"fetch": "https://www.volvocars.com/fr/legal/privacy/privacy-car",
"select": {
"startBefore": "h1",
"endBefore": "#vcc-site-footer"
}
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"name": "Volvo Cars",
"documents": {
"Privacy Policy": {
"executeClientScripts": true,
"fetch": "https://www.volvocars.com/fr/legal/privacy/privacy-car",
"select": {
"startBefore": "h1",
"endBefore": "#vcc-site-footer"
}
}
}
}
{
"name": "Volvo Cars",
"documents": {
"Privacy Policy": {
"combine": [
{
"fetch": "https://www.volvocars.com/fr/legal/privacy/privacy-car",
"select": [".bg-secondary"]
},
{
"fetch": "https://www.volvocars.com/fr/legal/privacy/privacy-dcv/",
"select": [".bg-secondary"]
},
{
"fetch": "https://www.volvocars.com/fr/legal/privacy/privacy-voc/",
"select": [".bg-secondary"]
}
],
"executeClientScripts": true
}
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants