-
Notifications
You must be signed in to change notification settings - Fork 4
add volvo cars #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add volvo cars #611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to make this contribution. I have reviewed it and would like to confirm a few things before approving it. While the declaration is clear and readable, the service appears to have multiple privacy statements, as noted on its website. Since we only have one terms type for these documents, I think it would be best to merge them all into a single privacy policy terms type.
I would like to hear @OpenTermsArchive/core's thoughts on this matter.
I share your point of view Clifford, the best thing is to bring documents together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the previous review and suggestion. I have managed to combine the 3 privacy policies of Volvo Cars. Please see the suggested change and merge them. I would have added the changes direclty but can't since it exists in a fork.
{ | ||
"name": "Volvo Cars", | ||
"documents": { | ||
"Privacy Policy": { | ||
"executeClientScripts": true, | ||
"fetch": "https://www.volvocars.com/fr/legal/privacy/privacy-car", | ||
"select": { | ||
"startBefore": "h1", | ||
"endBefore": "#vcc-site-footer" | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
"name": "Volvo Cars", | |
"documents": { | |
"Privacy Policy": { | |
"executeClientScripts": true, | |
"fetch": "https://www.volvocars.com/fr/legal/privacy/privacy-car", | |
"select": { | |
"startBefore": "h1", | |
"endBefore": "#vcc-site-footer" | |
} | |
} | |
} | |
} | |
{ | |
"name": "Volvo Cars", | |
"documents": { | |
"Privacy Policy": { | |
"combine": [ | |
{ | |
"fetch": "https://www.volvocars.com/fr/legal/privacy/privacy-car", | |
"select": [".bg-secondary"] | |
}, | |
{ | |
"fetch": "https://www.volvocars.com/fr/legal/privacy/privacy-dcv/", | |
"select": [".bg-secondary"] | |
}, | |
{ | |
"fetch": "https://www.volvocars.com/fr/legal/privacy/privacy-voc/", | |
"select": [".bg-secondary"] | |
} | |
], | |
"executeClientScripts": true | |
} | |
} | |
} |
No description provided.