-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BLDC token #18
Add BLDC token #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi.
Generally speaking, it is best not to create multiple PRs for the same code merge request.
Thanks for addressing some of my feedback from PR #16, however you don't seem to have addressed comments 1, 2, 4, and 6.
Standing by.
Description looks better! Still no chain-resolved metadata for b1899ba19c167d4ea9dcc64516b6295cdd7616b179b4146f461aacc623e14be6. Still no statement on the website? |
I added to website https://limonia.org/about-ldc |
Issue 2 remains: You appear to have no on-chain BCMR. This would be good to have. |
Check this new |
That is called a DNS-resolved registry. You can request more personalized help in the CashToken Devs group, where you are very welcome to ask as many questions as you like! |
Ok, thanks i will provide. |
Great work in updating your authead! It looks good to me. Now, you just need to update your PR here to match your new chain-resolved BCMR. |
Check new commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's now looking good. I am approving. Now you just need to wait for someone with write access to review your PR. Great work!
Ok, thanks. |
Thanks for your work here @7sxnc and @georgedonnelly! I fixed the merge conflicts and JSON errors, then I re-pinned your icon without the containing folder (still using nft.storage), and corrected the @7sxnc please let me know if you're OK with this changes, and I can merge the PR. 🚀 "b1899ba19c167d4ea9dcc64516b6295cdd7616b179b4146f461aacc623e14be6": {
"2024-01-17T18:26:16.811Z": {
"name": "Limones Digital Coin",
"description": "A fiduciary stablecoin with the aim of facilitating financial transactions within the Federation of Limonia and intermediating the exchange of foreign currencies. It is intended for use in online shopping, investments, loans, and digital network e-commerce services.",
"token": {
"category": "b1899ba19c167d4ea9dcc64516b6295cdd7616b179b4146f461aacc623e14be6",
"decimals": 2,
"symbol": "BLDC"
},
"uris": {
"icon": "ipfs://bafkreiaxleys6twenyiam2cztzrw7fewadz44cuvb5eozcro2cs2byyaqe",
"web": "https://limonia.org",
"support": "[email protected]",
"twitter": "https://twitter.com/govlimonia",
"chat": "https://discord.gg/CB5xRfWC5j"
}
}
}, |
It's okay |
I'm trying to create this pull request:
New Listing:
BLDC
Evidence Linking Authbase to Identity
Evidence Linking Identity to Authbase
Evidence Linking Authbase to Categories
category
is equal to the authbase for all Identity Snapshots.category
values below:Substantiation of Other Claims
description
) includes no claims requiring substantiation.Checklist
name
description
token
information (if applicable)category
is defined.category
,decimals
is defined.symbol
/^[A-Z0-9]+[-A-Z0-9]*$/
)uris.icon
Qm...
), trydweb.link
. For example,bafybeifv5l6foaqrxeux4dl7mj55d4a4lsthbrsyba3v6yqtarzbxcmn2m
is a v0 CID. It can be viewed athttps://d391b93f5f62d9c15f67142e43841acc.ipfscdn.io/ipfs/bafybeifv5l6foaqrxeux4dl7mj55d4a4lsthbrsyba3v6yqtarzbxcmn2m/a21966af10fabce599678eb258e69158.png
, which redirects to a subdomain equal to the v1 CID:https://d391b93f5f62d9c15f67142e43841acc.ipfscdn.io/
. The correct URI for this icon is:ipfs://QmaanKpq3bsHUrpJuASynqDurDeQbTYz6v35BLaD2BDmzS/a21966af10fabce599678eb258e69158.png
.SVG
format OR 400px by 400pxAVIF
,WebP
, orPNG
https://limonia.org
HTTPS
protocol OR ongoing activity demonstrated via optional URI identifiers (described in Substantiation of Other Claims)IPFS
with v1 CIDs to ensure file integrity (e.g.ipfs://ba...
).