revoke: Make check for conflicting files less intrusive #1272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinCanTech
force-pushed
the
revoke-conflicting-file-check-v2
branch
2 times, most recently
from
7d331ae to
16043e2
Compare
Ref: commit 38bf2d8 In order to avoid accidentally revoking an issued certificate, when an expired or renewed certificate is intended, guard command 'revoke' by checking for certificates of the same file-name in the 'expired' or 'renewed/issued' directories, first. Move the check to the revoke() function. Also, pass the target directory as the first argument to the revoke() function, instead of setting a variable in the command selection phase. Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech
force-pushed
the
revoke-conflicting-file-check-v2
branch
from
16043e2 to
0196300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: commit 38bf2d8
In order to avoid accidentally revoking an issued certificate, when an expired or renewed certificate is intended, guard command 'revoke' by checking for certificates of the same file-name in the 'expired' or 'renewed/issued' directories, first.
Move the check to the revoke() function.
Also, pass the target directory as the first argument to the revoke() function, instead of setting a variable in the command selection phase.