Command 'write': Remove options 'overwrite' and 'filename' #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinCanTech
added
BUG-FIX
X509-types
TinCanTech
force-pushed
the
write_legacy_file_v2-remove-auto-temp-file-overwrite
branch
from
73b4b5d to
1eaa841
Compare
Exposing command 'write' to the user was done to build confidence in the code. However, the way that is done must be controlled. Changes are as follows: * Remove options 'overwrite' and 'filename'. On the command line, only allow output to the console. * Remove internal auto-overwrite for temp-files. Internally, 'overwrite' and 'filename' remain and are consistent. Internal use now uses 'overwrite' for temp-files, deliberately. * Changes to 'verbose' output, which do not impact functionality. Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech
force-pushed
the
write_legacy_file_v2-remove-auto-temp-file-overwrite
branch
from
1eaa841 to
153ec6f
Compare
Signed-off-by: Richard T Bonhomme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command 'write': Remove options 'overwrite' and 'filename'
Exposing command 'write' to the user was done to build confidence
in the code. However, the way that is done must be controlled.
Changes are as follows:
On the command line, only allow output to the console.
Internally, 'overwrite' and 'filename' remain and are consistent.
Internal use now uses 'overwrite' for temp-files, deliberately.