Add: Add to GStreamer lcore mask support #1119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawidWesierski4
requested review from
Sakoram,
skolelis and
Falron98
as code owners
DawidWesierski4
force-pushed
the
add_lcore
branch
from
b63a4df to
e1b4535
Compare
- Add lcore masking support to allow users to specify the lcores the MTL plugin can use. This is useful for scenarios with isolated lcores. - Fix missing port and PTP arguments in gst common get arguments.
DawidWesierski4
force-pushed
the
add_lcore
branch
from
e1b4535 to
4f683fc
Compare
Sakoram
reviewed
Apr 1, 2025
|
|
||
| g_object_class_install_property( | ||
| gobject_class, PROP_GENERAL_LCORE_MASK, | ||
| g_param_spec_string("lcore-mask", "dpdk core mask", |
There was a problem hiding this comment.
naming this "mask" suggests that it should be used like --lcore-mask 00101 or even with single number like --lcore-mask 20 (representing binary mask as single number), but it should be used like --lcore-list 2,4. Consider renaming it.
| @@ -64,6 +65,7 @@ typedef struct GeneralArgs { | |||
| gchar dma_dev[MTL_PORT_MAX_LEN]; | |||
| gint log_level; | |||
| gboolean enable_onboard_ptp; | |||
| gchar lcore_mask[MTL_PORT_MAX_LEN]; | |||
There was a problem hiding this comment.
Why do we set all the arrays length to MTL_PORT_MAX_LEN? It is very confusing.
DawidWesierski4
force-pushed
the
add_lcore
branch
from
ad5a776 to
fdfec3d
Compare
- Mtl parses the lcore list but adds the main lcore to the list. This is not described anywhere and should be corrected.
DawidWesierski4
force-pushed
the
add_lcore
branch
from
fdfec3d to
33fa269
Compare
|
No time prioryty to add that, closing the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lcore masking support to allow users to specify the lcores the MTL plugin can use. This is useful for scenarios with isolated lcores.
Fix missing port and PTP arguments in gst common get arguments.