Add: GStreamer st40p plugins PTS timestamping #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DawidWesierski4
commented
Apr 23, 2025
DawidWesierski4
commented
Add the ability for MTL GStreamer st40p audio plugin to sue PTS clock for timestamping.
Fix the st40 pipeline mode API not including flags. Add parameters for PTS timestamping to the st40p pipeline plugin for the GSstreamer.
DawidWesierski4
requested review from
Sakoram,
skolelis and
Falron98
as code owners
DawidWesierski4
force-pushed
the
st40p_pts
branch
from
a900bcd to
37cd729
Compare
Some of the flags were not transmitted from the pipeline mode to legacy api.
DawidWesierski4
force-pushed
the
st40p_pts
branch
from
37cd729 to
111d9a4
Compare
DawidWesierski4
commented
Apr 23, 2025
Comment on lines
+480
to
+491
|
|
||
| if (ops->flags & ST40P_TX_FLAG_BLOCK_GET) | ||
| ctx->block_get = true; | ||
| } | ||
|
|
||
| if (ops->flags & ST40P_TX_FLAG_USER_TIMESTAMP) | ||
| ctx->ops.flags |= ST40_TX_FLAG_USER_TIMESTAMP; | ||
|
|
||
| if (ops->flags & ST40P_TX_FLAG_USER_PACING) | ||
| ctx->ops.flags |= ST40_TX_FLAG_USER_PACING; | ||
|
|
||
| if (ops->flags & ST40P_TX_FLAG_ENABLE_RTCP) | ||
| ctx->ops.flags |= ST40_TX_FLAG_ENABLE_RTCP; |
There was a problem hiding this comment.
I don't know i think it could be better to just copy the whole thing ? (·•᷄ࡇ•᷅ )
This solution hurts my soul but we need to be deliberate about what goes over
i hate this solution will take all sensible recommendations on it (¬_¬")
Sakoram
approved these changes
Apr 23, 2025
|
check CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.