-
-
Notifications
You must be signed in to change notification settings - Fork 66
feat: implement foreground service for android version #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nini22P, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the Android application by introducing persistent notifications for better user engagement and accessibility. It also includes a substantial refactoring effort to improve the app's modularity and maintainability, separating key functionalities and UI components. Additionally, the changes incorporate an exit confirmation dialog for a better user experience, update the Android API target and dependencies, and add a robustness improvement to the backend's directory handling.
Highlights
- Persistent Notifications: Implemented an ongoing notification for the Android application, providing quick access to the app's local web interface and status. This includes setting up notification channels and handling permission requests for Android 13 (API 33) and above.
- Android App Refactoring: Undertook a significant architectural refactoring of the Android application. Core functionalities such as asset management and notification handling have been extracted into dedicated modules, and Compose UI components have been modularized into separate files for improved maintainability and separation of concerns.
- Exit Confirmation Dialog: Introduced a confirmation dialog that appears when the user attempts to exit the application, warning about potential unsaved data loss. This enhances the user experience by preventing accidental exits.
- Dependency Updates and API Target: Updated various Android, Compose, and Kotlin dependencies, and raised the target API level to 33, aligning the application with newer Android versions and their features.
- Backend Robustness Improvement: Enhanced the backend logic to proactively check for the existence of the
Derivative_Engine
directory and create it if it's missing, ensuring smoother operation and preventing potential errors during directory access.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a notification feature for the Android app. It also refactors MainActivity
by extracting UI components and utility functions into separate files, improving code organization. A confirmation dialog is added for the back-press action.
This will keep the application running in the background for a long time.