Skip to content

Conversation

@viventaje
Copy link

@viventaje viventaje commented Feb 29, 2024

I offer my developments on a new render based on Open X-ray and using resources from CryEngine (fork - Lumberyard).
Support: DXIL

nouverbe and others added 30 commits February 3, 2024 13:28
+ fixed flickering in the menu and the game itself
+ fixed memory corruption in object initialization
+ fixed problem with screenshots
fixed low fps
@github-actions github-actions bot added the External (3rd party) This issue is related to external component used by our project. label Feb 29, 2024
@seionmoya
Copy link

That's really awesome!
Is the license Lumberyard's code is using compatible with this project's license?
https://github.com/aws/lumberyard/blob/master/LICENSE.txt

@Xottab-DUTY
Copy link
Member

I read Lumberyard licence briefly.
It looks like it doesn't allow using parts of it in other projects.
This PR does exactly that: it takes a part of Lumberyard to use it in non-Lumberyard project.
It is a problem.

@Xottab-DUTY
Copy link
Member

Xottab-DUTY commented Mar 27, 2025

So, we can't really merge this as it violates Lumberyard license, which explicitly prohibits extracting parts of it and integrating into different projects:

  1. Other Restrictions. Without limiting the restrictions set out in the Agreement and Intellectual Property License respectively, you may not (a) distribute the Lumberyard Materials in source code form, except as expressly permitted by Section 42.2(b) and (c), (b) use or exploit the Lumberyard Materials or any portion thereof to develop, maintain, participate in the development of, or support any competing engine, development tool, or software framework, (c) use the Lumberyard Materials or any portion thereof as part of a logo or trademark, (d) remove, obscure, or alter any proprietary rights notices (including copyright and trademark notices) contained in the Lumberyard Materials, (e) take any action that would require AWS, Inc. or you to license, distribute, or otherwise make available to anyone the Lumberyard Materials under different terms (e.g., combining Lumberyard Materials with software subject to "copyleft" open source licenses), or (f) use or exploit the Lumberyard Materials or any portion thereof in any manner or for any purpose other than as expressly permitted by these Terms.

However, this PR also contains changes to our own code, which are usable and can be separately imported.

One thing I can think about is https://github.com/o3de/o3de, which is distributed under Apache and MIT licenses. It might also have a translation layer that can be used?

Much thanks for the effort anyway!

@Xottab-DUTY
Copy link
Member

For those interested, there's a forum topic on AP-Pro: https://ap-pro.ru/forums/topic/7918-eksperimentalnyy-render-na-dvizhke-zova-pripyati-directx-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

External (3rd party) This issue is related to external component used by our project. Renderer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants