Skip to content

Conversation

@Emin017
Copy link

@Emin017 Emin017 commented Mar 1, 2025

  • Removed unused imports (scalafmt, os.Path, publish).
  • Standardized rocket-chip module definitions under millbuild namespace.
  • Updated defaultVersions to include sourcecode dependency.
  • Modified millSourcePath assignments to use super.millSourcePath.
  • Added mainargs and json4s-jackson as ivyDeps for rocket-chip.
  • Updated moduleDeps to reference renamed rocket-chip object.
  • Changed test module to use SbtTests instead of SbtModuleTests.
  • Improved consistency in dependency declarations across modules.
  • Bump mill from version 0.11.1 to 0.12.5

- Removed unused imports (`scalafmt`, `os.Path`, `publish`).
- Standardized `rocket-chip` module definitions under `millbuild`
namespace.
- Updated `defaultVersions` to include `sourcecode` dependency.
- Modified `millSourcePath` assignments to use `super.millSourcePath`.
- Added `mainargs` and `json4s-jackson` as `ivyDeps` for `rocket-chip`.
- Updated `moduleDeps` to reference renamed `rocket-chip` object.
- Changed test module to use `SbtTests` instead of `SbtModuleTests`.
- Improved consistency in dependency declarations across modules.

Signed-off-by: Qiming Chu <[email protected]>
@Emin017 Emin017 force-pushed the refactor-build-sc branch from 7ba7cdd to 8a5904c Compare March 2, 2025 08:49
@Kumonda221-CrO3 Kumonda221-CrO3 changed the title deps: refactor build.sc and bump dependencies chore(build): refactor build.sc and bump dependencies Mar 3, 2025
@Kumonda221-CrO3
Copy link
Contributor

Thank you for your attention!
But I'm sorry that this is not merging before some critical checkpoints of our verification roadmap.

@Emin017
Copy link
Author

Emin017 commented Mar 3, 2025

Is it because this projects are still using an old version of chisel? But I don't think the mill version will affect the verilog generation.

But I think it's understandable and I'm happy to wait for the necessary updates.

@Emin017
Copy link
Author

Emin017 commented Mar 3, 2025

It seems jodersky/[email protected] doesn't support to download mill version 0.12.5 , I'll try to fix this.

@Kumonda221-CrO3
Copy link
Contributor

Kumonda221-CrO3 commented Mar 3, 2025

Is it because this projects are still using an old version of chisel? But I don't think the mill version will affect the verilog generation.

But I think it's understandable and I'm happy to wait for the necessary updates.

We have several seperate teams and personnel working on different aspects of verification, and some environments and workspaces were designed to run offline. So at this point of time, it's might be not proper to introduce environmental jitters.

But still, we are very glad to have this kind support from you and your community!! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants