Add support for Eaton RF9640-N Dimmer #2515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chensquared
reviewed
Dec 25, 2020
| @@ -489,7 +489,9 @@ | |||
| <Manufacturer id="0132" name="DynaQuip Controls"></Manufacturer> | |||
| <Manufacturer id="010D" name="e-Home AUTOMATION"></Manufacturer> | |||
| <Manufacturer id="0247" name="EASY SAVER Co. Inc"></Manufacturer> | |||
| <Manufacturer id="001A" name="Eaton"></Manufacturer> | |||
| <Manufacturer id="001A" name="Eaton"> | |||
There was a problem hiding this comment.
Other Eaton devices (e.g. the 9540 predecessor) are under the Cooper manufacturer "001a" (lower case "a"). Consider putting the config there?
There was a problem hiding this comment.
Eaton acquired Cooper in 2012, so the Z-Wave Alliance certification listings for newer products have no mention of Cooper.
https://products.z-wavealliance.org/products/3152/
vs
https://products.z-wavealliance.org/products/797/
I think it is more clear to have Eaton as the manufacturer and migrate older Cooper devices to the Eaton folder in the future as Eaton is now the owner of '001a'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.