Fix Changelog and versions for release #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericnordelo
requested review from
immrsd and
andrew-fleming
and removed request for
immrsd
* update fmt * add missing dev dep * update scarb version in doc * add changelog entry * update changelog entry * Apply suggestions from code review Co-authored-by: Eric Nordelo <[email protected]> * add snforge entry to changelog * test coverage when not updating snforge * remove snforge entry from changelog * comment out cairo-coverage and codecov in ci * re-bump snforge * tmp remove coverage from command --------- Co-authored-by: Eric Nordelo <[email protected]>
andrew-fleming
approved these changes
Jan 22, 2025
| @@ -30,6 +30,7 @@ openzeppelin_token = { path = "../token" } | |||
| snforge_std.workspace = true | |||
| openzeppelin_testing = { path = "../testing" } | |||
| openzeppelin_test_common = { path = "../test_common" } | |||
| openzeppelin_utils = { path = "../utils" } | |||
Comment on lines
-1028
to
+1030
| voter, proposal_id, support, weight: voted_weight, reason, params | ||
| } | ||
| voter, proposal_id, support, weight: voted_weight, reason, params, | ||
| }, |
There was a problem hiding this comment.
🤞 that we don't go back to no trailing commas
Co-authored-by: Andrew Fleming <[email protected]>
…cts into fix/CHANGELOG-and-versions
…airo-contracts into fix/CHANGELOG-and-versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.