Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timelock operation hash (release) #1313

Conversation

andrew-fleming
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-v1.0.0@d493e25). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release-v1.0.0    #1313   +/-   ##
=================================================
  Coverage                  ?   95.22%           
=================================================
  Files                     ?       59           
  Lines                     ?     1488           
  Branches                  ?        0           
=================================================
  Hits                      ?     1417           
  Misses                    ?       71           
  Partials                  ?        0           
Files with missing lines Coverage Δ
.../governance/src/timelock/timelock_controller.cairo 89.32% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d493e25...ac0bd2f. Read the comment docs.

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@immrsd immrsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor suggestion regarding the changelog entry. Apart from that, LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
@andrew-fleming andrew-fleming merged commit 9b31696 into OpenZeppelin:release-v1.0.0 Jan 22, 2025
4 checks passed
@andrew-fleming andrew-fleming deleted the fix-timelock-operation_hash branch January 22, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants