Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SignerInfo packing issue (v1.0.0) #1316

Conversation

immrsd
Copy link
Collaborator

@immrsd immrsd commented Jan 22, 2025

Picks SignerInfo packing fix into the v1.0.0 release branch.

@immrsd immrsd self-assigned this Jan 22, 2025
@immrsd immrsd force-pushed the fix-signers-info-packing-to-v1.0.0 branch from 9bc1e32 to d750c0d Compare January 22, 2025 19:33
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-v1.0.0@d493e25). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ckages/governance/src/multisig/storage_utils.cairo 85.71% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release-v1.0.0    #1316   +/-   ##
=================================================
  Coverage                  ?   95.17%           
=================================================
  Files                     ?       59           
  Lines                     ?     1493           
  Branches                  ?        0           
=================================================
  Hits                      ?     1421           
  Misses                    ?       72           
  Partials                  ?        0           
Files with missing lines Coverage Δ
packages/governance/src/multisig/multisig.cairo 100.00% <ø> (ø)
...ckages/governance/src/multisig/storage_utils.cairo 92.85% <85.71%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d493e25...d750c0d. Read the comment docs.

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericnordelo ericnordelo self-requested a review January 23, 2025 11:57
@ericnordelo ericnordelo merged commit 5b9509e into OpenZeppelin:release-v1.0.0 Jan 23, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants