Skip to content

Add ERC7579 Executor modules #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 97 commits into from
May 16, 2025
Merged
Show file tree
Hide file tree
Changes from 93 commits
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
4711f42
Add SignerMultiERC7913 and SignerMultiERC7913Weighted
ernestognw Apr 21, 2025
0717223
Fix pragma
ernestognw Apr 21, 2025
1a2fad4
Fix pragma 2
ernestognw Apr 21, 2025
666ab9b
Add missing tests and fix issue in ERC7913Utils
ernestognw Apr 21, 2025
0e69b4c
Remove .only
ernestognw Apr 21, 2025
0e6eeec
nit
ernestognw Apr 21, 2025
19d2f1e
Update CHANGELOG.md
ernestognw Apr 21, 2025
2875b7c
Merge branch 'master' into feature/signer-multi-erc7913
ernestognw Apr 23, 2025
e812992
Update naming
ernestognw Apr 23, 2025
dd213b4
Fix tests
ernestognw Apr 23, 2025
28c2a99
Update docs/modules/ROOT/pages/multisig-account.adoc
ernestognw Apr 23, 2025
da1f4ff
Update docs/modules/ROOT/pages/multisig-account.adoc
ernestognw Apr 23, 2025
0d53def
Rename errors
ernestognw Apr 23, 2025
26e7e11
Update docs/modules/ROOT/pages/multisig-account.adoc
ernestognw Apr 23, 2025
1ca0f1e
Update docs/modules/ROOT/pages/multisig-account.adoc
ernestognw Apr 23, 2025
2728bff
Implement review suggestions
ernestognw Apr 23, 2025
2ba9a11
Unskip tests
ernestognw Apr 23, 2025
96c6405
Address review comments
ernestognw Apr 24, 2025
cdafc94
up
ernestognw Apr 24, 2025
7c6fbd4
Nits
ernestognw Apr 24, 2025
9634d0f
Fix tests
ernestognw Apr 24, 2025
33ea2c7
fix unreachable threshold bug, minor variable renamings
gonzaotc Apr 24, 2025
b41d3f3
fixed just introduced arithmetic underflow
gonzaotc Apr 24, 2025
e8b1557
Improve consistency of error and event naming
ernestognw Apr 24, 2025
cb22d0f
Update contracts/utils/cryptography/MultiSignerERC7913Weighted.sol
ernestognw Apr 24, 2025
8a424a3
Add extra isSigner function
ernestognw Apr 24, 2025
a8372f6
Pack threshold and totalWeight
ernestognw Apr 24, 2025
30bb001
Update docs
ernestognw Apr 24, 2025
be2e94f
Updates and moar test
ernestognw Apr 25, 2025
19f2912
Add ERC7579 Executor modules
ernestognw Apr 25, 2025
6cfa407
Simplify MultiSignerERC7913Weighted and reorder SignerERC7913
ernestognw Apr 26, 2025
1551e61
Move isValidNSignatures to ERC7913Utils
ernestognw Apr 26, 2025
b63009a
add tests
ernestognw Apr 26, 2025
4ec4be3
Update contracts/utils/cryptography/MultiSignerERC7913Weighted.sol
ernestognw Apr 26, 2025
81e6e26
Add ERC7579SignatureValidator
ernestognw Apr 26, 2025
d316450
Fix tests add docs
ernestognw Apr 26, 2025
e0361ca
Avoid using private _signersSet
ernestognw Apr 26, 2025
aec67c3
Fix tests
ernestognw Apr 26, 2025
822c678
Improve tests
ernestognw Apr 26, 2025
4377963
Up
ernestognw Apr 26, 2025
3a5ca9b
Merge branch 'master' into feature/erc7579-executors
ernestognw Apr 26, 2025
ffd8d23
Rename
ernestognw Apr 27, 2025
03007fa
Nits
ernestognw Apr 27, 2025
df9974e
up
ernestognw Apr 27, 2025
7be01b6
Nit
ernestognw Apr 27, 2025
2061c0c
Merge branch 'chore/erc7913-is-valid-n-signatures' into chore/multisi…
ernestognw Apr 27, 2025
174075e
Merge branch 'chore/multisig-nits' into feature/erc7579-signature-val…
ernestognw Apr 27, 2025
14eca65
Merge branch 'feature/erc7579-signature-validator' into feature/erc75…
ernestognw Apr 27, 2025
c1e0400
Iteration
ernestognw Apr 27, 2025
97a639c
up
ernestognw Apr 27, 2025
7315301
Merge branch 'master' into feature/erc7579-executors
ernestognw May 8, 2025
32051db
Remove unnecessary fil
ernestognw May 8, 2025
6b6bb41
Iterate
ernestognw May 8, 2025
a620544
Nit
ernestognw May 8, 2025
fc3e500
Nit
ernestognw May 8, 2025
636da55
add util function `isModuleInstalled` to avoid repeating
gonzaotc May 8, 2025
d3f8701
inline `isModuleInstalled` call
gonzaotc May 8, 2025
3a6c8bd
Apply suggestions from code review
ernestognw May 9, 2025
f8eb662
Apply review recommendations
ernestognw May 9, 2025
6ae1440
Fix test
ernestognw May 9, 2025
8a3903c
lint
ernestognw May 9, 2025
5f0b16d
Add missing note
ernestognw May 9, 2025
086b3c2
up
ernestognw May 9, 2025
4a8cab5
Add ERC7579MultisigConfirmation
ernestognw May 9, 2025
7c6a28a
Update contracts/account/modules/ERC7579MultisigConfirmation.sol
ernestognw May 9, 2025
baa1974
Add ERC7579Executor tests
ernestognw May 10, 2025
ea52273
Moar tests
ernestognw May 12, 2025
563dfe5
Add expiration to ERC7579MultisigConfirmation
ernestognw May 12, 2025
76b4b63
Update ERC7579DelayedExecutor
ernestognw May 13, 2025
aae8d44
More tests for ERC7579DelayedExecutor
ernestognw May 13, 2025
8e7f2ae
100% coverage delayed executor
ernestognw May 13, 2025
e312d0b
Moar tests
ernestognw May 13, 2025
da9ff1f
Moar tests
ernestognw May 13, 2025
5ec34e0
Moar tests
ernestognw May 13, 2025
94cb88c
nits
ernestognw May 13, 2025
a7389a0
Merge branch 'master' into feature/erc7579-executors
ernestognw May 13, 2025
4422833
Add executors to docs
ernestognw May 13, 2025
3e05f71
Apply suggestions from code review
ernestognw May 13, 2025
7c89c89
fix
ernestognw May 13, 2025
fdf0a50
Reverse order of errors in schedule, execute and cancel
ernestognw May 14, 2025
35324f2
Improve docs
ernestognw May 14, 2025
0065af1
Fix title levels in ERC7579DelayedExecutor
ernestognw May 14, 2025
9ea3743
Change _checkMultisignature for _validateMultisignature
ernestognw May 15, 2025
03f3fe5
Replace can* functions with internal _validate* in executors
ernestognw May 15, 2025
85047df
Reorder
ernestognw May 15, 2025
5557f70
Fix tests
ernestognw May 15, 2025
ab3c0ee
Simplify types
ernestognw May 15, 2025
c251f69
Use data to pack extra information on execution
ernestognw May 15, 2025
ec0ae9e
Change order of arguments to leave bytes data at the end
ernestognw May 15, 2025
700558d
Make schedule and cancel noops when not authorized
ernestognw May 16, 2025
23c683b
Revert "Make schedule and cancel noops when not authorized"
ernestognw May 16, 2025
24dad81
Revert on schedule if the module is not installed
ernestognw May 16, 2025
42a9fcb
Self-review
ernestognw May 16, 2025
0e1db84
Add more tests. Fix off by 1
ernestognw May 16, 2025
0968b48
Missing update
ernestognw May 16, 2025
aa8c0c2
reset libs
ernestognw May 16, 2025
ba3aae4
Codespell
ernestognw May 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions contracts/account/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ This directory includes contracts to build accounts for ERC-4337. These include:
* {ERC7821}: Minimal batch executor implementation contracts. Useful to enable easy batch execution for smart contracts.
* {ERC7579Validator}: Abstract validator module for ERC-7579 accounts that provides base implementation for signature validation.
* {ERC7579SignatureValidator}: Implementation of ERC7579Validator using ERC-7913 signature verification for address-less cryptographic keys.
* {ERC7579Multisig}: An abstract multisig module for ERC-7579 accounts using ERC-7913 signer keys.
* {ERC7579MultisigWeighted}: An abstract weighted multisig module that allows different weights to be assigned to signers.
* {ERC7579MultisigConfirmation}: An abstract confirmation-based multisig module that each signer to provide a confirmation signature.
* {ERC7579Executor}: An executor module that enables executing calls from accounts where the it's installed.
* {ERC7579DelayedExecutor}: An executor module that adds a delay before executing an account operation.
* {PaymasterCore}: An ERC-4337 paymaster implementation that includes the core logic to validate and pay for user operations.
* {PaymasterERC20}: A paymaster that allows users to pay for user operations using ERC-20 tokens.
* {PaymasterERC20Guarantor}: A paymaster that enables third parties to guarantee user operations by pre-funding gas costs, with the option for users to repay or for guarantors to absorb the cost.
Expand All @@ -30,6 +35,18 @@ This directory includes contracts to build accounts for ERC-4337. These include:

== Modules

{{ERC7579Multisig}}

{{ERC7579MultisigWeighted}}

{{ERC7579MultisigConfirmation}}

=== Executors

{{ERC7579Executor}}

{{ERC7579DelayedExecutor}}

=== Validators

{{ERC7579Validator}}
Expand Down
Loading
Loading