Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide two variant of ERC4626Fees with different models #8

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Provide two variant of ERC4626Fees with different models #8

wants to merge 6 commits into from

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jul 30, 2024 •
edited
Loading

@cairoeth lets do the maxXxxx changes here.

@Amxx Amxx requested a review from a team as a code owner July 30, 2024 09:14
Amxx
Amxx commented Jul 30, 2024
View reviewed changes
contracts/token/ERC4626Fees.sol Outdated Show resolved Hide resolved
Amxx
Amxx commented Jul 30, 2024
View reviewed changes
contracts/token/ERC4626Fees.sol Outdated Show resolved Hide resolved
@Amxx Amxx force-pushed the refactor/erc4626fees branch from 5636637 to 2be359f Compare July 30, 2024 11:57
@Amxx
Merge branch 'refactor/erc4626fees' of github.com:OpenZeppelin/openze…
1be9def 
…ppelin-contracts-experimental into refactor/erc4626fees
@Amxx Amxx force-pushed the refactor/erc4626fees branch from 2be359f to 1be9def Compare July 30, 2024 12:04
ernestognw
ernestognw previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way this is exposed, it's clear both options are different and the description is good too. LGTM

@ernestognw ernestognw dismissed their stale review July 30, 2024 17:01

Notice we're missing the maxXXX updates

@Amxx
Copy link
Collaborator Author

Amxx commented Jul 31, 2024

Notice we're missing the maxXXX updates

This should be taken care of in the main contract (ERC4626) using pr #5130 of the main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @ernestognw