Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite assembly slot offset for consistency #5325

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rewrite assembly slot offset for consistency #5325

wants to merge 4 commits into from

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Nov 27, 2024 •
edited
Loading

Fixes #5324 (comment)

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 551945a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Amxx
Amxx commented Nov 27, 2024
View reviewed changes
contracts/utils/Strings.sol Outdated Show resolved Hide resolved
Amxx
Amxx commented Nov 27, 2024
View reviewed changes
contracts/utils/Strings.sol Outdated Show resolved Hide resolved
@Amxx Amxx added this to the 5.3 milestone Nov 28, 2024
@ernestognw ernestognw changed the title Rewrite assembly slot offset for consistencty Rewrite assembly slot offset for consistency Jan 7, 2025
@ernestognw
Copy link
Member

Any reason not to merge this @Amxx?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @ernestognw