Skip to content

Add saturating (unsigned) math operations and optimize try operations #5527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 24, 2025

Simpler version of #5029 that only supports signed operations

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 260eb7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx Amxx added this to the 5.3 milestone Feb 24, 2025
@arr00 arr00 changed the title Add saturating (unsigned) math operations Add saturating (unsigned) math operations and optimize try operations Feb 24, 2025
ernestognw
ernestognw previously approved these changes Feb 25, 2025
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nits. Looks good

luiz-lvj
luiz-lvj previously approved these changes Feb 25, 2025
arr00
arr00 previously approved these changes Feb 25, 2025
@Amxx Amxx merged commit a9b1f58 into OpenZeppelin:master Feb 27, 2025
17 checks passed
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Feb 27, 2025
@Amxx Amxx deleted the features/saturating-operation-unsigned branch February 27, 2025 09:05
@Amxx Amxx mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants