Make Votes.sol _validateTimepoint virtual#6400
Make Votes.sol _validateTimepoint virtual#6400gonzaotc wants to merge 1 commit intoOpenZeppelin:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 4a8adc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request adds a changeset for a patch release of openzeppelin-solidity and modifies the governance utilities. The 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
contracts/governance/utils/Votes.sol (1)
78-81: Add a regression test for the new override hook.This change fixes a source-level inheritance issue, but the PR should also prove it with a test: a derived contract that overrides
_validateTimepointacross multiple bases and verifies that the past-lookup entry points still route through that override. Without that, this compatibility fix can regress silently.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a67b7c1e-fb5d-4f18-9950-80eba57dcb62
📒 Files selected for processing (2)
.changeset/wicked-dingos-wish.mdcontracts/governance/utils/Votes.sol
Makes
Votes.sol_validateTimepointvirtual, neccesary when combiningERC20Voteswith other contracts that implement_validateTimepoint